Allow extra_paths to be placed in front of sys.path#527
Allow extra_paths to be placed in front of sys.path#527ccordoba12 merged 6 commits intopython-lsp:developfrom
extra_paths to be placed in front of sys.path#527Conversation
bbe70c1 to
976bcfe
Compare
0fedcae to
12aafe6
Compare
|
I reviewed the PR but I won't merge myself because I have no experience with this repo. The failing tests seem unrelated but it may be worthwhile to re-run them (I can't find the button, perhaps I don't have the necessary permissions). Also, somebody needs to answer this question from Ryan:
|
|
Thank you for reviewing this, @jitseniesen. To clarify, Pinging @ccordoba12. |
ccordoba12
left a comment
There was a problem hiding this comment.
Thanks @mrclary for your work on this! I just left some suggestions to improve clarity for you.
cdf9ab5 to
4ce1776
Compare
|
@mrclary, please rebase again on top of |
|
@ccordoba12, will this require a minor version bump? |
* Add pylsp.plugins.jedi.prioritize configuration key Note: when safe to break API, Document.sys_path should be removed.
Co-authored-by: Carlos Cordoba <ccordoba12@gmail.com>
|
I think this one is ready, so I'll include it in 1.12.0. Although in Spyder it's going to take until 6.1 to take advantage of these changes. |
extra_paths to be placed in front of sys.path
Add
pylsp.plugins.jedi.prioritizeconfiguration key and prepend/appendextra_pathsto the environmentsys.pathaccordingly.This modifies the call signature of
Document.sys_path. Will this require a minor release bump?